-
Notifications
You must be signed in to change notification settings - Fork 65
build(kernel): sync pinned kernel revision #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| dd810d6d0a179886b923c6e22dc785ddca16ebef | ||
| 167651ecc67143ef258ad70fd2682ced00beaa99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 Low — This PR rewrites the user-facing session-conf docs to claim the kernel now forwards
WithSessionParamsunchanged with no allowlist (here, plus the removed "Kernel session-conf allowlist" section and theWithSessionParamsrow flipped⚠️ → ✅). But the PR description states the shipped bindings dependency is unchanged and the no-allowlist behavior only exists in the source-built pinnedKERNEL_REV(167651e), pending the 1.1.0 bindings.CONNECTION_PARAMETERS.md / README are consumed by users of the released driver, who link the older published bindings that (per the text being deleted) still allowlist-filter and drop non-allowlisted keys with a warning. Until 1.1.0 ships, a consumer reading these docs will expect an arbitrary conf (e.g. a non-allowlisted key) to be forwarded, when their linked kernel still drops it. Consider gating this doc change on the bindings bump, or noting that the unfiltered-forwarding behavior applies from kernel 1.1.0 onward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kernel change is already in 1.0.0 binding https://github.com/databricks/databricks-sql-kernel/pull/303. This is a doc update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks — you may well be right that the change rode along in the published
v1.0.0binding. My concern was specifically that the docs describe unfiltered forwarding for users linking the released bindings, and I can't confirm from this repo alone thatdatabricks-sql-kernel-bindings v1.0.0(the pin ingo.mod) actually contains the no-allowlist behavior from kernel PR #303 — that module's contents live outside this checkout. If a maintainer can confirm the shippedv1.0.0archive is built from a kernel rev that includes #303 (rather than the behavior only being present in the source-builtKERNEL_REV), this is fully resolved and the docs are accurate as written. Leaving the thread open only so that binding-version confirmation isn't lost.