Add agent_api_root and search_scope configuration options - #212
Merged
Conversation
keyurva
had a problem deploying
to
evals-and-secrets
July 24, 2026 07:20 — with 
GitHub Actions
Error
GitHub Actions
Error
keyurva
had a problem deploying
to
evals-and-secrets
July 24, 2026 07:21 — with
GitHub Actions
Error
GitHub Actions
Error
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for DC_AGENT_API_ROOT and DC_SEARCH_SCOPE configurations to the Data Commons MCP package, allowing more granular control over Agent API endpoints and search scopes. Key changes include updating AgentAPIClient to accept and pass the search scope, improving exception handling, and adding corresponding unit tests. Feedback recommends simplifying the initialization in app.py by avoiding dynamic attribute checks on the Pydantic settings model, and truncating the error body in AgentAPIError.str to prevent log flooding from large API responses.
keyurva
had a problem deploying
to
evals-and-secrets
July 24, 2026 17:43 — with
GitHub Actions
Error
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DC_AGENT_API_ROOTenvironment variable and configuration setting for Agent API base endpoints.DC_SEARCH_SCOPEenvironment variable and configuration setting to control query search target scope.