Automation of import Finland_Census #2087
Conversation
There was a problem hiding this comment.
Code Review
This pull request automates the import process for the Finland Demographics Dataset by introducing a data_download.py script to fetch data from the Statistics Finland PxWeb API and a run.sh script to orchestrate the download and processing. The README.md and manifest.json have been updated to document and support this automated refresh. Feedback on the changes suggests using the standard csv module in data_download.py to robustly parse headers containing commas, and quoting the wildcard pattern in run.sh to prevent unintended shell expansion.
|
@smarthg-gi : Please add golden checks to the validation |
Added golden checks |
smarthg-gi
left a comment
There was a problem hiding this comment.
Added the comments
…g-gi/data into Finland_Census_automation
Import name =
Finland_CensusPR checklist = Doc
Overview
Automation of Finland Demographics Dataset (
Finland_Census) understatvar_imports/.Key Changes
data_download.pywhich leverages existingutil/download_util.pyfor data download.run.shandmanifest.jsonwith the correct cron schedule and file paths to trigger the download and processing of the data.test_data/.Verification & Validation Proofs
Local CI Presubmit:
./run_tests.sh -apasses 100% (unit tests +yapf --style=googleformatting check).Verification:
stat_var_processor.pyexecuted againsttest_data/finland_census_input.csv;git diff test_data/is clean.Data Commons Lint Check: Executed
java -jar datacommons-import-tool.jar lint output_files/*.csv.Result: 0 errors, 0 warnings. All generated StatVar DCIDs and TMCF references conform to schema rules.