adding goldens for BLS imports#2090
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds golden summary reports for the c_cpi_u and cpi_u datasets. The reviewer pointed out that the golden summary report for cpi_w is missing and should be added to ensure complete test coverage for all datasets defined in the manifest.
balit-raibot
changed the title
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request introduces validation configurations and golden summary reports for the US BLS CPI and CES State data imports, updating their manifests to reference the new validation files. The reviewer identified that the relative paths to the golden summary reports in both validation_config.json files are incorrect, pointing to non-existent directories by going up four levels instead of three. Correcting these paths is necessary to ensure the validation runner can locate the golden files.
…-raibot/data into adding_goldens_bls_imports
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request adds validation configurations and golden summary reports for several US Bureau of Labor Statistics (BLS) datasets, including CPI, JOLTS, and CES State. Specifically, it introduces validation_config.json files to define validation rules (such as deleted records percentage thresholds and golden data checks) and updates the respective manifest.json files to reference them. It also adds the corresponding golden summary report CSV files. As there are no review comments, I have no feedback to provide.
|
LGTM |
| { | ||
| "schema_version": "1.0", | ||
| "rules": [ | ||
| { |
There was a problem hiding this comment.
Goldens check for places are missing from this file. Please add the same
There was a problem hiding this comment.
hi @pulkeet-wq this import doesn't have observationAbout column in the observations output file.
The import has only one observation about which is being used by .tmcf file.
| "schema_version": "1.0", | ||
| "rules": [ | ||
| { | ||
| "rule_id": "check_deleted_records_percent", |
There was a problem hiding this comment.
Golden checks for places are missing from this file. please add the same
There was a problem hiding this comment.
hi @pulkeet-wq this import doesn't have observationAbout column in the observations output file.
The import has only one observation about which is being used by .tmcf file.
3 participants
This PR adds golden data for BLS imports: BLS_CPI, BLS_CES_State, BLS_JOLTS, BLS_CPI_Category and US_CPI.
NOTE: BLS_CPI and BLS_JOLTS don't have observationAbout column in the observations output file.
The imports have only one observation about which is being used by .tmcf file.