Adding goldens to NCES_Bachelors_Degree_By_Field_Import and NCES_HBCU_Enrollment_Import#2096
Open
smarthg-gi wants to merge 4 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces golden data files and a validation configuration for NCES bachelor's degree imports, enabling automated checks for both male and female educational attainment datasets. A critical issue was identified in validation_config.json where the golden file path for check_goldens_male_latest_observations was incorrectly configured to point to a summary report instead of the observations file.
smarthg-gi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports:
NCES_Bachelors_Degree_By_Field_Import
NCES_HBCU_Enrollment_Import
This PR includes:
Added goldens with 0.1% increase in threshold
PR Checklist: https://docs.google.com/spreadsheets/d/1_vmnJ9eFYFCq0JYikWSvMDoDY1DLxphRlohDOhuOdrE/edit?resourcekey=0--hVe9fbOAp_kCat_ElGcKg&gid=0#gid=0