Conversation
babris
requested review from
absurdfarce,
alicel,
grighetto,
joao-r-reis,
lukasz-antoniak and
weideng1
as code owners
February 5, 2025 17:33
babris
force-pushed
the
helm-chart-custom-secret-names-and-cdm-enabler
branch
from
February 5, 2025 22:58
933e694 to
6995112
Compare
|
mbabris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
in my use case of the Helm chart, I need to have two separate releases active in the same Kubernetes namespace, each with different configuration values to account for an outlying client application that connects to a different origin cluster.
Currently, this isn't possible, since the expected secret name is hard-coded as
zdmproxyandzdmproxy-scb.In my ideal form of the chart, users would be able to alter the name of the secret such that different releases can be supplied with different configuration values. Additionally, giving users an option to disable creation of the
cdmpod as well as the SCB volume mount would help accommodate non-Astra DB target clusters.This PR adds four fields to the helm values to achieve this:
secretNameOverride: Overrides the expected secret name,"zdmproxy"by defaultsecretScbNameOverride: Overrides the expected SCB secret name,"zdmproxy-scb"by defaultcdm.enabled: Determines whether acdmdeployment is created ("true"by default)scb.enabled: Determines whether a SCB volume mount is created from secretzdmproxy-scb("true"by default)"target_origin_points"will be expected in the"zdmproxy"secretThe defaults exist such that if users do not supply any of the above values, the original functionality is preserved.
With this PR, I hope to welcome a discussion on the above topics as well as any change suggestions.
Thank you for your review.