Repository navigation
[epic] Springclean and update Giftless (2023/2024) - for latest python etc #126
Description
Giftless has not had a makeover since ~2020/2021 so an update is in order and @athornton is leading the charge 🙏
Acceptance
## Updates
- [x] Have it work with modern python versions **✅2023-12-28 in #124 and #125**
- [x] Lint with a modern linter e.g. black #130
- [x] Maintainable test suite #136
- [ ] https://github.com/datopian/giftless/issues/174
- [x] Or, just (or additionally) push to ghcr.io, which simplifies authentication somewhat #135
- [x] generally spiffing up pre-commit hooks and GHA #135
- [ ] Update docs to flag support for AWS etc
Tasks
- [ ] #124
- [ ] #125
Activity
[-][epic] Overhaul Giftless (2023/2024) - for Python 2[/-][+][epic] Springclean and update Giftless (2023/2024) - for latest python etc[/+]athornton commentedon Jan 12, 2024
Moving in the right direction: a lot of linting cleanup is done, and there's a PR to use Ruff in flight. I picked Ruff because it's what Rubin Observatory is now using internally, and it replaces all of flake8, black, and isort all at once, which is very handy. It's extremely opinionated, but also very configurable. I'm using basically the same set of rules we use, which might not be quite what Datopian wants, but it's a place to start.
After that I'm going to modernize Github actions and try to get the Google storage test working again, which will mean dropping pytest-vcr from it. After that if I have remaining time budget I might try to do the same for the AWS and Azure storage tests, but at least those are still working for now.
athornton commentedon Jan 12, 2024
Github Actions are updated too with a PR to add those also in flight.
Mostly, if I'm being honest, because I'm avoiding diving into the test suite, which I will tackle next week.
athornton commentedon Jan 15, 2024
#134 was exchanged for #135.
#136 is now open, and that at least touches everything but the doc updates. The current state (with #136 merged) isn't great, in that the mock basically just turns Google storage into local storage, but I am worried that I couldn't get a client that mocked HTTP responses working by the end of the week, which is all the time I have.
athornton commentedon Jan 15, 2024
I'm going to need Datopian help for:
Once we've done that, we can cut a new release. I think this one should be 0.6.0 because it's a pretty big change from the previous version.
rufuspollock commentedon Jan 16, 2024
@anuveyatsu or @demenech could you take a quick look at @athornton requests above - that will allow us to automate things going forward.
athornton commentedon Jan 30, 2024
Just bumping this. It won't take very long, although actually scheduling a 30 minute Zoom-or-equivalent call for me to talk whoever on the Datopian side through the various tasks may be more efficient than GitHub comments or conversation on the Discord. I have a little availability this week and then I'm at a conference next week.
rufuspollock commentedon Jan 30, 2024
@demenech is there a chance you can schedule this with @athornton (via discord is probably easiest). Then we can have this setup 😄
@athornton thanks for all the forward progress! 👏
demenech commentedon Feb 1, 2024
hi @rufuspollock
The issue on my end is that I don't have the necessary credentials i.e. Dockerhub and PyPi credentials.
If these are provided to me I'm glad to help.
rufuspollock commentedon Feb 1, 2024
@demenech I would ask @anuveyatsu then. We may no longer publish to dockerhub so other options are possible. Pypi is crucial one and we need to look into the datopian account credentials there.
devinnasar commentedon Feb 2, 2024
Does this refresh cover the signing version that I mention in #106?
rufuspollock commentedon Mar 22, 2024
@devinnasar it could if you get a PR in 🙂
rufuspollock commentedon Dec 6, 2024
@athornton i've split out pypi release to #173 and docker stuff to #174. I suggest we close this as fixed (i'll leave you with the honors) and prioritize those two.