Repository navigation
test: add release tests, rework bats setup to match other add-ons - #72
Merged
Merged
Conversation
## Short Summary (TL;DR) Restores the release test (run only on schedule and `workflow_dispatch`) and reworks `tests/test.bats` to match ddev-sqlsrv and ddev-solr. ## The Issue The `install from release` test was removed in #38 when tests were split by `bats_tag`, so nothing checks that `ddev add-on get ddev/ddev-frankenphp` still works. The test setup also repeated the same config, install, and restart steps in every test. ## How This PR Solves The Issue - Adds back the `install from release` test with the `release` tag. - Adds `release` to the `bats_tag` matrix only on `schedule` and `workflow_dispatch`, the same as ddev-redis and ddev-sqlsrv. - Adds an `install_from_directory <php_version>` helper, and passes the PHP version to `health_checks` instead of using `FRANKENPHP_PHP_VERSION`. - Copies the default `index.php` in `setup()`. - Renames tests to the `install from directory PHP X.Y` format. Tags are unchanged. ## Manual Testing Instructions ```bash ddev add-on get ddev/ddev-frankenphp --pr 72 ddev restart ``` ## Automated Testing Overview - `bats tests --filter-tags '!release'` runs the same 6 tests as before. - `bats tests --filter-tags release` runs the new release test. ## Release/Deployment Notes Only tests and CI are changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary (TL;DR)
Restores the release test (run only on schedule and
workflow_dispatch) and reworkstests/test.batsto match ddev-sqlsrv and ddev-solr.The Issue
The
install from releasetest was removed in #38 when tests were split bybats_tag, so nothing checks thatddev add-on get ddev/ddev-frankenphpstill works.The test setup also repeated the same config, install, and restart steps in every test.
How This PR Solves The Issue
install from releasetest with thereleasetag.releaseto thebats_tagmatrix only onscheduleandworkflow_dispatch, the same as ddev-redis and ddev-sqlsrv.install_from_directory <php_version>helper, and passes the PHP version tohealth_checksinstead of usingFRANKENPHP_PHP_VERSION.index.phpinsetup().install from directory PHP X.Yformat. Tags are unchanged.Manual Testing Instructions
Automated Testing Overview
bats tests --filter-tags '!release'runs the same 6 tests as before.bats tests --filter-tags releaseruns the new release test.Release/Deployment Notes
Only tests and CI are changed.
🤖 Generated with Claude Code