fix:add OpenMP parallelization to BPCG CPU kernel band loops (assisted with Deepseek V4)#7400
Open
Missing-Hex wants to merge 4 commits into
Open
fix:add OpenMP parallelization to BPCG CPU kernel band loops (assisted with Deepseek V4)#7400Missing-Hex wants to merge 4 commits into
Missing-Hex wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Add OpenMP parallelization to BPCG CPU kernels for improved performance
Unit Tests and/or Case Tests for my changes
source/source_hsolver/kernels/test/cover the BPCG functionalityWhat's changed?
#pragma omp parallel for) to the outer band loops inline_minimize_with_block_op<CPU>andcalc_grad_with_block_op<CPU>inbpcg_kernel_op.cpp#pragma omp criticalsections to protect MPI reduction calls (Parallel_Reduce::reduce_pool) ensuring thread safety#ifdef _OPENMPfor conditional compilation, maintaining backward compatibility with non-OpenMP buildsAny changes of core modules? (ignore if not applicable)
HSolvermodule: Enhancedbpcg_kernel_op.cppwith OpenMP parallelization for CPU kernelsline_minimize_with_block_opandcalc_grad_with_block_opstructures which are critical for BPCG diagonalization performance