Skip to content

Refactor: extract shared ion–cell geometry operations from simultaneous CG - #8337

Open
Growl1234 wants to merge 1 commit into
deepmodeling:developfrom
Growl1234:relax
Open

Growl1234 wants to merge 1 commit into
deepmodeling:developfrom
Growl1234:relax

Conversation

@Growl1234

@Growl1234 Growl1234 commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

This is a prerequisite for moving towards #7970.

@Growl1234 Growl1234 added Refactor Refactor ABACUS codes GeometryRelaxation Issues related to geometry relaxation labels Nov 19, 2026
@Growl1234
Growl1234 marked this pull request as ready for review November 20, 2026 05:01

@ABACUS-PR-BOT ABACUS-PR-BOT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review found no introduced correctness defect in this extraction.

Non-blocking: Please record the actual validation commands, configuration and observed results for the extraction and new regression cases in the PR description, including checks that were not run.

Reviewed 9edc0acbb7d4 against eba09c937c73. git diff --check passed; builds and tests were not run, and CI results were not verified.

Comment thread source/source_relax/relax_sync.cpp Resolved
Comment thread source/source_relax/relax_sync.cpp Resolved
@Growl1234

Copy link
Copy Markdown
Collaborator Author

The CUDA failure seems unrelated to this PR as I didn't touch LCAO code.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GeometryRelaxation Issues related to geometry relaxation Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants