Skip to content

feat(mgmt): allow updating management key roles - #826

Merged
dorsha merged 1 commit into
mainfrom
feat/mgmt-key-update-roles
Nov 1, 2026
Merged

dorsha merged 1 commit into
mainfrom
feat/mgmt-key-update-roles

Conversation

@dorsha

@dorsha dorsha commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Related Issues

Required for:
https://github.com/descope/etc/issues/19637

Description

managementKey.update takes an optional trailing reBac argument that replaces the key's roles without rotating its secret. Leaving it out keeps the key's current roles, so existing calls behave the same.

In a Nutshell

  • Optional reBac on managementKey.update
  • Sent only when provided
  • README: role update example, and the update example's argument order fixed

Related PRs

Related PRs

Must

  • Tests
  • Documentation (if applicable)

🤖 Generated with Claude Code

managementKey.update accepts an optional reBac argument that replaces the
key's roles without rotating its secret. When omitted, the key keeps its
current roles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

🐕 Shuni Review

No new issues found.

🤖 Model: claude-opus-5.5 · Effort: high


Review scope: Full review

Reviewed files (3)
  • README.md
  • lib/management/managementKey.ts
  • lib/management/managementKey.test.ts

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: high

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@dorsha
dorsha requested a review from aviadl October 29, 2026 12:08
@dorsha
dorsha enabled auto-merge (squash) October 29, 2026 12:08
@dorsha
dorsha disabled auto-merge November 1, 2026 09:31
@dorsha
dorsha merged commit 419e5eb into main Nov 1, 2026
29 checks passed
@dorsha
dorsha deleted the feat/mgmt-key-update-roles branch November 1, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant