Repository navigation
docs(readme): give the deployer role explicit verbs - #50
Merged
Merged
Conversation
ciaransweet
approved these changes
Nov 10, 2026
`*` on roles and rolebindings includes escalate and bind.
ciaransweet
force-pushed
the
docs/deployer-role-explicit-verbs
branch
from
November 10, 2026 14:02
22a414b to
362829d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deployerRole in "Kubernetes cluster setup" granted*. Onrolesandrolebindingsthat includesescalateandbind, so a leaked deploy token could grant itself any permission in the namespace. The verbs are now listed: same resources, and still enough for the deploy workflow, since themcp-indexRole it creates only grants permissions the deployer already holds.For reviewers: this changes new setups only. An existing instance keeps its Role until someone edits it (
kubectl -n <namespace> edit role deployer).How this was made
Claude Code drafted the change; @lhoupert asked for it and approved the diff. The README command as written was run as a server-side dry run against a cluster running this template, and it creates the Role with the listed verbs. With the same Role, impersonating
deployer:escalateandbindare refused, and creating themcp-indexRole and RoleBinding still works. A real CI deploy with it has not run yet.— Claude Code, on behalf of @lhoupert