feat(devices): add network settings management for AMT devices#3370
feat(devices): add network settings management for AMT devices#3370shaoboon wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an enterprise-only “Network Settings” experience for AMT devices, including wired configuration controls, wireless enable/sync toggles, and CRUD management for wireless profiles, backed by new DevicesService endpoints and updated models/i18n.
Changes:
- Adds/expands the Network Settings tab UI to configure wired network settings and manage wireless settings + profiles (including 802.1x credential upload handling).
- Introduces new request/response models and new
DevicesServiceendpoints for wired/wireless network configuration. - Updates i18n strings and adds unit tests for the new service methods and component wiring.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/models/models.ts | Exports additional network-related model interfaces and adds request/response types for wired/wireless operations. |
| src/assets/i18n/en.json | Adds new UI strings for network settings configuration and profile management; updates network settings description text. |
| src/app/devices/network-settings/network-settings.component.ts | Implements wired save flow, wireless state/sync save flow, wireless profile CRUD flow, and credential file-to-base64 handling. |
| src/app/devices/network-settings/network-settings.component.html | Reworks the UI into config + details cards and adds wireless profile management + upload controls. |
| src/app/devices/network-settings/network-settings.component.scss | Adds layout/styling for the new forms, profile list, and upload UI. |
| src/app/devices/network-settings/network-settings.component.spec.ts | Expands component test setup with additional DevicesService spies and dialog mocking. |
| src/app/devices/devices.service.ts | Adds wired/wireless network settings endpoints for state, sync toggles, and wireless profile CRUD. |
| src/app/devices/devices.service.spec.ts | Adds unit tests validating new endpoints’ HTTP methods/URLs/bodies. |
|
@shaoboon Three full-width SAVE buttons in blue/grey don't fit well here. Instead, use right-aligned, auto-width buttons (mat-flat-button for the action, mat-button text for Cancel; Cancel left / action right) and apply the same pattern to all three so they're consistent. |
addressed |
697dd38 to
053d3a1
Compare
5f9a766 to
164b347
Compare
9fb4982 to
84ee95d
Compare
|
@shaoboon A few small UX updates for the Wireless page:
These would make the wireless state and potential connection-impacting actions clearer to the user. Otherwise, it looks good to me. |
good point, on a similar note, im thinking to apply the warning to any settings that might interrupt the connection like disabling wifi, static ip with different ip from the connected ip and etc. |
4c47dc2 to
47fc7ca
Compare
Add a Network Settings tab to the device view for managing wired and wireless network configuration directly on a device. Wired: - View link/IP details and IEEE 802.1x status - Configure DHCP or static IP, with IP synchronization Wireless: - View link/IP details and toggle Wi-Fi state - Manage local and UEFI profile synchronization - Create, edit and delete wireless profiles (sorted by priority) - Support PSK and IEEE 802.1x auth; for 802.1x, PEAP uses a password and EAP-TLS uploads client certificate, private key and optional CA certificate (uploaded as base64 DER, matching the backend) Add the corresponding DevicesService endpoints, request/response models. Includes unit tests for the new service methods and component. Resolves: #3353 created network specific enabled/disabled labels fix fix



PR Checklist
What are you changing?
Add a Network Settings tab to the device view for managing wired and wireless network configuration directly on a device.
Wired:
Wireless:
Add the corresponding DevicesService endpoints, request/response models. Includes unit tests for the new service methods and component.
Resolves: #3353
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )
UI sample
wired
wireless