Skip to content

feat(devices): add network settings management for AMT devices#3370

Open
shaoboon wants to merge 1 commit into
mainfrom
sb_network
Open

feat(devices): add network settings management for AMT devices#3370
shaoboon wants to merge 1 commit into
mainfrom
sb_network

Conversation

@shaoboon

@shaoboon shaoboon commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Add a Network Settings tab to the device view for managing wired and wireless network configuration directly on a device.

Wired:

  • View link/IP details and IEEE 802.1x status
  • Configure DHCP or static IP, with IP synchronization

Wireless:

  • View link/IP details and toggle Wi-Fi state
  • Manage local and UEFI profile synchronization
  • Create, edit and delete wireless profiles (sorted by priority)
  • Support PSK and IEEE 802.1x auth; for 802.1x, PEAP uses a password and EAP-TLS uploads client certificate, private key and optional CA certificate (uploaded as base64 DER, matching the backend)

Add the corresponding DevicesService endpoints, request/response models. Includes unit tests for the new service methods and component.

Resolves: #3353

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

UI sample

wired

image

wireless

image image

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an enterprise-only “Network Settings” experience for AMT devices, including wired configuration controls, wireless enable/sync toggles, and CRUD management for wireless profiles, backed by new DevicesService endpoints and updated models/i18n.

Changes:

  • Adds/expands the Network Settings tab UI to configure wired network settings and manage wireless settings + profiles (including 802.1x credential upload handling).
  • Introduces new request/response models and new DevicesService endpoints for wired/wireless network configuration.
  • Updates i18n strings and adds unit tests for the new service methods and component wiring.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/models/models.ts Exports additional network-related model interfaces and adds request/response types for wired/wireless operations.
src/assets/i18n/en.json Adds new UI strings for network settings configuration and profile management; updates network settings description text.
src/app/devices/network-settings/network-settings.component.ts Implements wired save flow, wireless state/sync save flow, wireless profile CRUD flow, and credential file-to-base64 handling.
src/app/devices/network-settings/network-settings.component.html Reworks the UI into config + details cards and adds wireless profile management + upload controls.
src/app/devices/network-settings/network-settings.component.scss Adds layout/styling for the new forms, profile list, and upload UI.
src/app/devices/network-settings/network-settings.component.spec.ts Expands component test setup with additional DevicesService spies and dialog mocking.
src/app/devices/devices.service.ts Adds wired/wireless network settings endpoints for state, sync toggles, and wireless profile CRUD.
src/app/devices/devices.service.spec.ts Adds unit tests validating new endpoints’ HTTP methods/URLs/bodies.

Comment thread src/app/devices/network-settings/network-settings.component.ts
Comment thread src/app/devices/network-settings/network-settings.component.ts
Comment thread src/app/devices/network-settings/network-settings.component.ts Outdated
Comment thread src/app/devices/network-settings/network-settings.component.ts Outdated
Comment thread src/app/devices/network-settings/network-settings.component.ts Outdated
Comment thread src/app/devices/network-settings/network-settings.component.ts
Comment thread src/app/devices/network-settings/network-settings.component.ts Outdated
@madhavilosetty-intel

Copy link
Copy Markdown
Contributor
  1. Conflicting messages
image

@madhavilosetty-intel

madhavilosetty-intel commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
  1. Vertical alignment between two cards - Especially in DHCP mode left card is mostly empty. Mismatched Trash icons
image

@madhavilosetty-intel

Copy link
Copy Markdown
Contributor

@shaoboon Three full-width SAVE buttons in blue/grey don't fit well here. Instead, use right-aligned, auto-width buttons (mat-flat-button for the action, mat-button text for Cancel; Cancel left / action right) and apply the same pattern to all three so they're consistent.

@shaoboon

shaoboon commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author
  1. Vertical alignment between two cards - Especially in DHCP mode left card is mostly empty. Mismatched Trash icons
image

changed to tab view to address this issue, also fixed the mismatched trach icons.

@shaoboon

Copy link
Copy Markdown
Contributor Author

@shaoboon Three full-width SAVE buttons in blue/grey don't fit well here. Instead, use right-aligned, auto-width buttons (mat-flat-button for the action, mat-button text for Cancel; Cancel left / action right) and apply the same pattern to all three so they're consistent.

addressed

@shaoboon shaoboon force-pushed the sb_network branch 2 times, most recently from 697dd38 to 053d3a1 Compare June 19, 2026 12:29
@shaoboon shaoboon requested a review from Copilot June 19, 2026 12:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Comment thread src/app/devices/network-settings/network-settings.component.ts
Comment thread src/app/devices/network-settings/network-settings.component.ts
Comment thread src/app/devices/network-settings/network-settings.component.ts Outdated
Comment thread src/app/devices/network-settings/network-settings.component.spec.ts
Comment thread src/app/devices/network-settings/network-settings.component.html
Comment thread src/app/devices/network-settings/network-settings.component.html
@shaoboon shaoboon force-pushed the sb_network branch 2 times, most recently from 5f9a766 to 164b347 Compare June 23, 2026 13:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Comment thread src/app/devices/network-settings/network-settings.component.html Outdated
Comment thread src/app/devices/network-settings/network-settings.component.html Outdated
Comment thread src/app/devices/network-settings/network-settings.component.html
Comment thread src/app/devices/network-settings/network-settings.component.html Outdated
Comment thread src/app/devices/network-settings/network-settings.component.spec.ts Outdated
@shaoboon shaoboon force-pushed the sb_network branch 3 times, most recently from 9fb4982 to 84ee95d Compare June 26, 2026 11:15
@madhavilosetty-intel

Copy link
Copy Markdown
Contributor

@shaoboon A few small UX updates for the Wireless page:

  • Under the current wireless status, can we show whether WiFi is enabled or disabled, along with the UEFI profile sharing and local profile synchronization status?
  • When WiFi is disabled and the user clicks Add profiles, can we show an alert instead of letting them continue without context?
  • When the user selects Static together with IP sync, can we show a warning like: “You might lose the connection if the OS is using DHCP.”

These would make the wireless state and potential connection-impacting actions clearer to the user. Otherwise, it looks good to me.

@shaoboon

shaoboon commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

When the user selects Static together with IP sync, can we show a warning like: “You might lose the connection if the OS is using DHCP.”

good point, on a similar note, im thinking to apply the warning to any settings that might interrupt the connection like disabling wifi, static ip with different ip from the connected ip and etc.

@shaoboon shaoboon force-pushed the sb_network branch 3 times, most recently from 4c47dc2 to 47fc7ca Compare June 30, 2026 10:39
Add a Network Settings tab to the device view for managing
wired and wireless network configuration directly on a device.

Wired:
- View link/IP details and IEEE 802.1x status
- Configure DHCP or static IP, with IP synchronization

Wireless:
- View link/IP details and toggle Wi-Fi state
- Manage local and UEFI profile synchronization
- Create, edit and delete wireless profiles (sorted by priority)
- Support PSK and IEEE 802.1x auth; for 802.1x, PEAP uses a password
  and EAP-TLS uploads client certificate, private key and optional
  CA certificate (uploaded as base64 DER, matching the backend)

Add the corresponding DevicesService endpoints, request/response models.
Includes unit tests for the new service methods and component.

Resolves: #3353

created network specific enabled/disabled labels

fix

fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add wired and wireless device network configuration UI

3 participants