GameCube/Wii port of SDL3 - #132
Open
mardy wants to merge 14 commits into
Open
Conversation
We should consider absolute even paths like sd:/ and usb:/
The draw_screen_rect() function was assuming that the GX vertex format was left the same since the initialization, but that's not the case if the mouse gets drawn (or if GL calls happen in between frames). This issue appears only when directly drawing to the framebuffer, which is something games rarely do; however, the "software" renderer in SDL operates on the FB, therefore the problem can be currently seen until we implement the render backend in SDL3. The render backend in SDL2 directly draws using GX functions, so it's not affected by this issue (but it might be worth fixing it there, too).
We are not enabling it since the GX backend is preferrable (it doesn't depend on opengx), but it's good to know that this also works.
These only take up space in the program's code.
…n if possible" This reverts commit be45038. Causes libsdl-org#16156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An SDL3 port to the Wii and GameCube, derived from the SDL2 port. One commit fixes an issue that might affect the SDL2 version too, although I've never seen it happening there.
I've tested this both on Dolphin and on a real Wii using these programs from the test suite:
The OpenGL-based renderer can be built and works fine with opengx, but it's currently excluded from the build since we probably prefer the GX backend, which avoids the opengx dependency.
Existing Issue(s)