#2211: Delete PythonUrlUpdater and related files - #2220
Conversation
Coverage Report for CI Build 30643519386Coverage decreased (-0.05%) to 72.61%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions18 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
oanding-blrng
left a comment
There was a problem hiding this comment.
The project and the module are passing can be compiled and passed are tests. The UpdateManager.java doesn't create/use the PythonUrlUpdater.java and therefore no crawling regarding the URL defined in the PythonUrlUpdater.java should be made.
After fixing the CHANGELOG.adoc and updating the branch to the latest commit of main, this PR can move forward.
hohwille
left a comment
There was a problem hiding this comment.
@Paras14 thanks for your PR. Great to do some cleanup. 👍
I have some formatting question that we should clarify but must not block this PR.
Also you should apply the review suggestion from @oanding-blrng
Then we can merge.
Co-authored-by: OAnding <oscar.anding@capgemini.com>
…aras14/IDEasy into 2211-delete-python-url-updater
Co-authored-by: OAnding <oscar.anding@capgemini.com> Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
|
Deleted code is gone, nothing else to re-test. |
This PR fixes #2211
Implemented changes:
PythonUrlUpdaterand its supporting classesPythonFile,PythonJsonObjectandPythonRelease, together withPythonUrlUpdaterTestand its test resource.PythonUrlUpdaterimport and its entry in the updater list inUpdateManager.uv python list(PythonRepository) instead ofide-urls, so the Python URL metadata is no longer used for installing Python and does not need to be crawled anymore.dependencies.jsonandsecurity.jsoninide-urlsremain in use (findDependencies/findSecurity) and are untouched by this PR.ide-urlsis a separate PR (Delete python version metadata (devonfw/IDEasy#2211) ide-urls#45) in thedevonfw/ide-urlsrepository, which must only be merged after this PR, because the nightlyupdate-urlsworkflow would otherwise regenerate the deleted folders.Testing instructions
mvn clean test, all tests pass and the build is successful.UpdateManagerno longer referencesPythonUrlUpdaterand that the url-updater module still compiles and runs for the remaining tools.Update URLSworkflow no longer writes new Python versions intoide-urls; existing Python metadata stays untouched.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal