#2361: Improved dotnet installation - #2341
Conversation
Coverage Report for CI Build 32739066120Coverage increased (+0.01%) to 73.504%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
|
Thanks for the PR. Aside from the wrong positioning of the Changelog entry, I tested the changes on both Windows and Linux (WSL).Here are my findings: My Suggestions, Could you please double-check the command on Linux? If this requires specific local setup, it would be great to update the PR description with the necessary prerequisites for testing. |
I think we need to give this an extra look. I'm testing on Arch, could it be something to do with WSL? Regardless, I'll give it a proper look tomorrow morning |
|
Afer a call with Majeste we confirmed that his issue was because of a missing library on his setup, moving this to Review |
There was a problem hiding this comment.
@MeShehi thanks for your PR. Nice improvement. 👍 Seems that Microsoft with .NET does not follow common convetions to use DOTNET_HOME variable but DOTNET_ROOT.
Therefore your PR is a reasonable improvement. However, as I mentioned you are associating the wrong issue here.
|
I created a new issue and changed the referenced issue in this PR |
|
Successfully tested with 2026.08.002 on Windows:
|
|
Successfully tested with 2026.08.002 on Linux(WSL):
|
This PR fixes #2361
Implemented changes:
Testing instructions
Run the cli configuration with the following:
uninstall dotnetinstall dotnetenvide dotnet --infoChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc