Repository navigation
Conversation
…gs-cancel-parity # Conflicts: # .github/workflows/pr-ci.yml # sites/docs-devsy-sh/content/docs/developing-providers/runtime-protocol.mdx
✅ Deploy Preview for devsydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canceled MicroSandbox commands could remain blocked while copying an owned input stream, even after the child process exited. Agent binary transfer had the same problem because its progress wrapper hid the source closer. Close eligible non-file input on cancellation, join the callback before returning, and close each acquired transfer source exactly once so retries receive a fresh source. Normal completion, failed starts, caller-owned files, existing transfer limits, and original cancellation causes retain their behavior.
Add six actual-VM scenarios across the built-in driver and published external provider v0.1.7: completed stdout/stderr logs while running and stopped, cancellation of a ready parent/child tree, and cancellation with blocked owned stdin. Independent PID/start-time/nonce observation checks process death within the same ten-second cancellation bound; VM creation time, boot ID, subsequent command execution, and source contents must survive. The external test path uses the real self-executed runtime supervisor and prepared executable. Each cleanup owns only its recorded process or previously absent VM identity.
Validation:
This does not establish TTY or arbitrary nonclosable-input cancellation, binary log fidelity or ordering, runtime compatibility failures, invalid-recreate preservation, host hardening, or existing-workspace migration. Built-in-provider cutover remains separately gated.