chore: Bump current certification version to V29 - #11184
Draft
mraszyk wants to merge 2 commits into
Draft
Conversation
All mainnet subnets run replica versions supporting up to `V29` (`release-2026-08-06_04-21-fix-repro` and `release-2026-08-13_03-55-base`, both with `MAX_SUPPORTED_CERTIFICATION_VERSION == V29`), so the current certification version can be bumped to `V29`. This makes the fixed `consumed_cycles_total` (which no longer double counts the cycles consumed by deleted canisters and additionally includes the cycles consumed by all non-deleted canisters) visible in `/subnet/<subnet_id>/metrics`. `SystemMetadata` encodes the current certification version, hence the expected hashes in `rs/state_manager/src/manifest/split/tests.rs` had to be updated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All mainnet subnets run replica versions supporting up to
V29(release-2026-08-06_04-21-fix-reproandrelease-2026-08-13_03-55-base, both withMAX_SUPPORTED_CERTIFICATION_VERSION == V29), so the current certification version can be bumped toV29.This makes the fixed
consumed_cycles_total(which no longer double counts the cycles consumed by deleted canisters and additionally includes the cycles consumed by all non-deleted canisters) visible in/subnet/<subnet_id>/metrics.SystemMetadataencodes the current certification version, hence the expected hashes inrs/state_manager/src/manifest/split/tests.rshad to be updated.