feat: Do not route canister messages from a cooling down subnet - #11193
Open
mraszyk wants to merge 1 commit into
Open
feat: Do not route canister messages from a cooling down subnet#11193mraszyk wants to merge 1 commit into
mraszyk wants to merge 1 commit into
Conversation
Messages (requests and responses) in canister output queues are no longer routed into streams while the source subnet is cooling down. They are retained in their output queues until the subnet stops cooling down, rather than being rejected or dropped. This includes the loopback stream, i.e. a cooling down subnet does not route its canisters' messages to its loopback stream either. The check is merged into the existing destination side check, so a queue is skipped (and counted in `mr_cooling_down_skipped_queues`) exactly once per round, whether it is the source subnet, the destination subnet, or both that are cooling down. As before, messages from the subnet's own output queues are exempt. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
✅ No security or compliance issues detected. Reviewed everything up to e60f5e5. Security Overview
Detected Code Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages (requests and responses) in canister output queues are no longer routed into streams while the source subnet is cooling down. They are retained in their output queues until the subnet stops cooling down, rather than being rejected or dropped. This includes the loopback stream, i.e. a cooling down subnet does not route its canisters' messages to its loopback stream either.
The check is merged into the existing destination side check, so a queue is skipped (and counted in
mr_cooling_down_skipped_queues) exactly once per round, whether it is the source subnet, the destination subnet, or both that are cooling down. As before, messages from the subnet's own output queues are exempt.