Skip to content

chore: Even better error messages for invalid keys - #11198

Open
schneiderstefan wants to merge 2 commits into
masterfrom
stschnei/pubkey-errors2
Open

chore: Even better error messages for invalid keys#11198
schneiderstefan wants to merge 2 commits into
masterfrom
stschnei/pubkey-errors2

Conversation

@schneiderstefan

Copy link
Copy Markdown
Contributor

This is a follow-up to commit 42f67fe giving fine-grained error messages for some more cases of invalid pubkeys.

This is a follow-up to commit 42f67fe giving fine-grained error messages
for some more cases of invalid pubkeys.
@schneiderstefan
schneiderstefan requested a review from a team as a code owner August 18, 2026 14:14
@github-actions github-actions Bot added the chore label Aug 18, 2026
@zeropath-ai

zeropath-ai Bot commented Aug 18, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 819b14b.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► rs/crypto/internal/crypto_lib/basic_sig/der_utils/src/lib.rs
    Improve DER parsing: add SEQUENCE/SET handling, more robust nesting depth checks, and length/empty element handling
► rs/crypto/internal/crypto_lib/basic_sig/der_utils/src/tests.rs
    Add extensive tests for DER parsing, nesting depth counting, and malformed DER scenarios

Comment thread rs/crypto/internal/crypto_lib/basic_sig/der_utils/src/lib.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants