feat(subnet-splitting): preemptively load the post-split DKG transcripts in the key manager - #11205
Draft
pierugo-dfinity wants to merge 1 commit into
Draft
Conversation
When a subnet split is scheduled, the DKG interval of the `Scheduled` summary is skipped, so its transcripts are never used. Instead the key manager computes the post-split summary from the registry and loads its transcripts, and retains them in the concurrent key removal so the keys it just loaded don't get dropped again.
Contributor
There was a problem hiding this comment.
Pull request overview
Preloads post-split DKG transcripts when a scheduled subnet split is finalized and retains their key material during concurrent cleanup.
Changes:
- Detects scheduled splits and loads the appropriate post-split transcripts.
- Retains newly loaded transcripts during inactive-key removal.
- Updates constructors and adds split coverage.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
rs/replica/setup_ic_network/src/lib.rs |
Supplies registry and replica configuration. |
rs/replay/src/validator.rs |
Updates replay key-manager construction. |
rs/consensus/tests/payload.rs |
Updates test construction. |
rs/consensus/tests/framework/runner.rs |
Updates framework construction. |
rs/consensus/src/consensus.rs |
Updates consensus test setup. |
rs/consensus/dkg/src/payload_validator.rs |
Updates validator test setup. |
rs/consensus/dkg/src/lib.rs |
Propagates new constructor dependencies. |
rs/consensus/dkg/src/dkg_key_manager.rs |
Implements post-split loading, retention, and tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a subnet split is scheduled, the DKG interval of the
Scheduledsummary is skipped, so its transcripts are never used. Instead, the DKG key manager should load the transcripts of the soon-to-be created post-split block as soon as such a summary is detected. This is needed to have the necessary key material needed to sign shares for the post-split CUP.We also make sure to retain the transcripts in the concurrent key removal so the keys it just loaded don't get dropped again.