Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions src/corner/arviz_corner.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
__all__ = ["arviz_corner"]

import logging
import re
from collections.abc import Mapping

import numpy as np
Expand All @@ -18,24 +17,8 @@
# arviz < 1.0
from arviz.utils import _var_names, get_coords
except ImportError:
# arviz >= 1.0: these functions were removed

def _var_names(var_names, dataset, filter_vars=None):
if var_names is None:
return None
if filter_vars == "like":
return [
v
for v in dataset.data_vars
if any(vn in v for vn in var_names)
]
elif filter_vars == "regex":
return [
v
for v in dataset.data_vars
if any(re.search(vn, v) for vn in var_names)
]
return list(var_names)
# arviz >= 1.0: variable selection moved to arviz_base
from arviz_base.utils import _var_names

def get_coords(dataset, coords):
if not coords:
Expand Down
51 changes: 51 additions & 0 deletions tests/test_arviz_selection.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# -*- coding: utf-8 -*-

import numpy as np
import pytest
from matplotlib import pyplot as pl

import corner


@pytest.mark.parametrize(
"var_names, filter_vars, expected",
[
(["~theta"], None, ["mu", "tau"]),
(["~the"], "like", ["mu", "tau"]),
(["~^the.*"], "regex", ["mu", "tau"]),
("mu", None, ["mu"]),
("tau", "like", ["tau"]),
("^mu$", "regex", ["mu"]),
(["theta", "mu"], None, ["theta", "mu"]),
(["tau"], "like", ["tau"]),
(["^mu$"], "regex", ["mu"]),
],
)
def test_arviz_variable_selection(var_names, filter_vars, expected):
az = pytest.importorskip("arviz")
rng = np.random.default_rng(42)
posterior = {
name: rng.normal(size=(2, 100)) for name in ["mu", "tau", "theta"]
}
try:
data = az.from_dict(posterior=posterior)
except TypeError:
data = az.from_dict({"posterior": posterior})
fig = corner.corner(
data,
var_names=var_names,
filter_vars=filter_vars,
quantiles=[0.5],
plot_contours=False,
)
try:
ndim = len(expected)
assert len(fig.axes) == ndim**2
for i, name in enumerate(expected):
# The median line checks selection against the original draws.
ax = fig.axes[i * ndim + i]
np.testing.assert_allclose(
ax.lines[0].get_xdata(), np.median(posterior[name])
)
finally:
pl.close(fig)