Repository navigation
Deprecate: Deprecate all camel case functions in fitbase #140
Description
Problem
We still use camel case function naming and we want to move to snake case. The following files need to be review for deprecation:
-
__init__.py -
calculator.py -
configurable.py -
constraint.py -
fitcontribution.py -
fithook.py -
fitrecipe.py -
fitresults.py -
parameter.py -
parameterset.py -
profile.py -
profilegenerator.py -
profileparser.py -
recipeorganizer.py -
restraint.py -
simplerecipe.py -
validatable.py
Proposed solution
Follow instructions in scikit-package 0.3.0 documentation for how to deprecate a function. if 0.3.0 hasnt been released yet, you can build the documentation locally for these instructions.
Activity
[-]Deprecate: Deprecate all functions under `fitbase`[/-][+]Deprecate: Deprecate all functions camel case functions[/+][-]Deprecate: Deprecate all functions camel case functions[/-][+]Deprecate: Deprecate all camel case functions[/+][-]Deprecate: Deprecate all camel case functions[/-][+]Deprecate: Deprecate all camel case functions in `fitbase`[/+]cadenmyers13 commentedon Feb 27, 2026
@sbillinge I just got to thinking, do we want the
.create_new_variable,.add_variable, and.delete_variablemethods to becreate_new_parameter,add_parameter, anddelete_parameter? Im forgetting which is which 😂edit: I think no, right? because we define variables in constraint equations right
sbillinge commentedon Feb 27, 2026
ooh, yes, this is our chance to fix the parameter-variable dichotomy and never have to apologise for it ever again.
Parameters belong to the model
Variables are varied in the regressor.
they are linked by the constraint equations.
I think addVar() is correct usage. It is adding a variable to the regression. It would take as argument a relation involving one or moer paramters. The ones you mention above I am not sure about. Let's give it some thought and come up with a compreshensive plan....we could do a global search for var and par as a start?
Let's do this.
stevenhua0320 commentedon Apr 11, 2026
@sbillinge @cadenmyers13 I'm curious about the status of this issue? I saw Caden has finished most of the deprecation process, so is this now finished?
cadenmyers13 commentedon Apr 13, 2026
@stevenhua0320 Yeah this can be closed, thanks for catching
cadenmyers13 commentedon Apr 13, 2026
closing as complete