Skip to content

Update README.rst#302

Open
kehach07 wants to merge 2 commits into
django:mainfrom
kehach07:patch-1
Open

Update README.rst#302
kehach07 wants to merge 2 commits into
django:mainfrom
kehach07:patch-1

Conversation

@kehach07

Copy link
Copy Markdown

Update README static asset paths and Docker SCSS commands for local Trac setup

Comment thread README.rst Outdated
``cp -rT ../djangoproject.com/static/js trac-env/htdocs/js``
4. Compile trackhacks.scss:
``make compile-scss``
``cp -rT ../djangoproject.com/djangoproject/static/js trac-env/htdocs/js``

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The T option didn't worked for me, did it worked for you like that @kehach07 ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sabderemane,

Yes, it worked on my setup. I believe the -rT option was already present before my changes, so I kept it as is.

From what I understand, -T treats the destination as a normal path instead of creating an additional nested directory. If -T is not working on your environment, we could use an alternative such as:

cp -r ../djangoproject.com/djangoproject/static/js/* trac-env/htdocs/js/

or

cp -r ../djangoproject.com/djangoproject/static/js/. trac-env/htdocs/js/

which should copy the contents into the destination directory without relying on the -T flag.

Let me know what you think.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think we could stick to the first one, technically we don't have any dot files in the js folder to copy so worth to stick to the first command.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks , i will update that

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabderemane Hi, I’ve made the requested changes. Please let me know if anything else is required.

@sabderemane sabderemane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Keha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants