build: resolve target links for call methods - #3992
Open
okhowang wants to merge 1 commit into
Open
Conversation
Targets referencing each other through a "target:" named context are resolved on the client: the linked target is solved first and its result is then rewritten into an "input:" context by waitContextDeps. A call method such as check or outline replies with the metadata of the subrequest and does not return a build result, so nothing can be linked into the targets depending on it. The "target:" context is then left untouched and reaches the frontend, which rejects it: $ docker buildx bake -f providers.hcl -f build.hcl app --check app error: unsupported context source target for base base error: unsupported context source target for builder Solve the build request separately when a target using a call method is linked to by another one, and register that result for them. It is never evaluated, so the definition is only resolved and nothing is built. Checks are skipped for that request as they are already reported by the call method, otherwise a Dockerfile asking for check violations to be errors would fail it before the report is produced. Fixes docker#3343 Signed-off-by: okhowang(王沛文) <okhowang@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets referencing each other through a "target:" named context are resolved on the client: the linked target is solved first and its result is then rewritten into an "input:" context by waitContextDeps.
A call method such as check or outline replies with the metadata of the subrequest and does not return a build result, so nothing can be linked into the targets depending on it. The "target:" context is then left untouched and reaches the frontend, which rejects it:
$ docker buildx bake -f providers.hcl -f build.hcl app --check
app
error: unsupported context source target for base
base
error: unsupported context source target for builder
Solve the build request separately when a target using a call method is linked to by another one, and register that result for them. It is never evaluated, so the definition is only resolved and nothing is built. Checks are skipped for that request as they are already reported by the call method, otherwise a Dockerfile asking for check violations to be errors would fail it before the report is produced.
Fixes #3343