Repository navigation
Fix --discover false enabling recording - #1977
Open
waldekmastykarz wants to merge 1 commit into
Open
waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
Only enable recording when --discover is true. Previously any value, including false, turned recording on. Closes dotnet#1957 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4accf12-c9fb-4311-806c-5ed628b79d22
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix matches the reported requirements, preserves existing recording settings, and includes regression coverage.
No open issues 🎉
What changed in this PR
Fixes #1957 so --discover false no longer enables recording in Dev Proxy.
Changes:
- Extracts discovery handling into
ApplyDiscoverOption, enabling recording only when discovery is explicitly true. - Adds regression tests covering true, false, omitted values, and preservation of existing recording settings.
| File | Description |
|---|---|
| DevProxy/Commands/DevProxyCommand.cs | Corrects and extracts discovery option handling. |
| DevProxy.Tests/DevProxyCommandTests.cs | Tests discovery’s effect on recording settings. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1957
--discover falsesetRecord = truebecause the check wasisDiscover is not null. Recording is now enabled only when--discoveristrue. The logic is extracted toDevProxyCommand.ApplyDiscoverOptionand covered by unit tests inDevProxy.Tests.