Repository navigation
Fix TypeSpecGeneratorPlugin log messages to mention TypeSpec - #1978
Open
waldekmastykarz wants to merge 1 commit into
Open
waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
TypeSpecGeneratorPlugin logged "Writing OpenAPI spec" / "Created OpenAPI spec file" when writing .tsp files. Log messages now refer to TypeSpec files, and the integration test asserts the messages. Closes dotnet#1975 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4afa2bd8-e47d-4362-b7fd-412d95af4216
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused correction matches the issue requirements and includes regression coverage, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Corrects TypeSpec generator log messages to identify .tsp output accurately, addressing #1975.
Changes:
- Replaces OpenAPI wording with TypeSpec in two log messages.
- Adds regression assertions for the corrected messages and absence of OpenAPI wording.
| File | Description |
|---|---|
| DevProxy.Plugins/Generation/TypeSpecGeneratorPlugin.cs | Corrects debug and information log messages. |
| DevProxy.Integration.Tests/GenerationPluginsIntegrationTests.cs | Captures logs and verifies TypeSpec wording. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeSpecGeneratorPlugin logged "Writing OpenAPI spec…" and "Created OpenAPI spec file…" when writing
.tspfiles (copy-paste from OpenApiSpecGeneratorPlugin). The messages now say "Writing TypeSpec file to…" and "Created TypeSpec file…".The existing
TypeSpecGenerator_WritesSpecintegration test now captures log messages and asserts them (fails before the fix, passes after).Closes #1975