Repository navigation
Remove non-existent /swagger endpoint from root help - #1981
Open
waldekmastykarz wants to merge 1 commit into
Open
waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
The API no longer serves an OpenAPI description (Swashbuckle was removed in dotnet#1647), so the help pointed to a URL that returns 404. Endpoints are discoverable via 'devproxy api show', which the help already mentions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 21412cff-89bf-42ec-a0fd-9932695d825d
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused help-text correction satisfies the issue’s requirements without changing API behavior.
No open issues 🎉
What changed in this PR
Corrects root help by removing the nonexistent /swagger endpoint reference, resolving #1963.
Changes:
- Removes the misleading OpenAPI URL while retaining
devproxy api showguidance for endpoint discovery.
| File | Description |
|---|---|
| DevProxy/Commands/DevProxyCommand.cs | Removes the invalid Swagger URL from root help. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root help advertised an OpenAPI spec at
<api-url>/swagger, but no Swagger/OpenAPI middleware has been registered since Swashbuckle was removed in #1647, so the URL returns 404. This removes the line; the help already points todevproxy api showfor endpoint discovery.Closes #1963