Repository navigation
Determine JsonReporter file extension per report - #1984
Open
waldekmastykarz wants to merge 1 commit into
Open
waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
Reset the file extension to .json for each report so that the .jsonc extension of the UrlDiscovery report doesn't leak into subsequent reports. Closes dotnet#1965 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 54b42df4-1c9b-48e8-b160-86954c55ede8
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix addresses the reported defect with targeted regression coverage and no identified blocking issues.
No open issues 🎉
What changed in this PR
Fixes #1965 by determining JsonReporter’s file extension independently for each report.
Changes:
- Resets the extension to
.jsonbefore processing each report. - Adds regression coverage for a JSON report following a UrlDiscovery report.
| File | Description |
|---|---|
| DevProxy.Plugins/Reporters/JsonReporter.cs | Resets the default extension per report. |
| DevProxy.Integration.Tests/JsonReporterTests.cs | Verifies .jsonc does not carry over to subsequent JSON reports. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonReporter stored the report file extension in a field that was set to
.jsoncby the UrlDiscovery report and never reset, so JSON reports written after it also got the.jsoncextension. The extension is now reset to.jsonfor each report.Adds a test verifying the extension is determined per report.
Closes #1965