Repository navigation
Report unset API Center environment variables - #1985
Open
waldekmastykarz wants to merge 1 commit into
Open
waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
When an API Center setting references an environment variable with @name and the variable isn't set, throw an error naming the variable instead of silently using the literal @name value. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 53023532-b4f0-4cd7-a238-b890b15ce83a
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change uses existing plugin error handling, and no blocking issues were identified; tests were not executed.
No open issues 🎉
What changed in this PR
Reports missing API Center environment variables during initialization instead of allowing misleading Azure errors later.
Changes:
- Centralizes environment-variable resolution and throws a descriptive
ArgumentExceptionfor missing or empty values. - Adds tests for unset and populated environment variables.
| File | Description |
|---|---|
| DevProxy.Plugins/ApiCenter/ApiCenterClient.cs | Validates environment-variable references across API Center settings. |
| DevProxy.Integration.Tests/ApiCenterClientTests.cs | Tests missing-variable errors and successful value resolution. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1968
API Center plugin settings support
@NAMEto read an environment variable. When the variable wasn't set, the literal@NAMEwas used, causing an unrelated Azure error later.Now
ApiCenterClientthrowsArgumentException(e.g.Environment variable FOO referenced by subscriptionId isn't set.), consistent with the existing config validation. API Center plugins already catch this, log the error, and disable themselves.Added
ApiCenterClientTestscovering unset and set variables.