Repository navigation
Default Content-Type to application/json for generic error and custom rate-limit responses - #1986
Open
waldekmastykarz wants to merge 1 commit into
Open
waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
… rate-limit responses GenericRandomErrorPlugin and RateLimitingPlugin (custom response) now add Content-Type: application/json when the response has a body and no Content-Type header is configured, matching MockResponsePlugin. Closes dotnet#1971 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b01cdbfd-df85-41d9-925d-3fe22389de95
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow changes preserve configured headers and have focused integration coverage, with no blocking issues identified; tests were not executed.
No open issues 🎉
What changed in this PR
Aligns generated error and custom rate-limit responses with mock-response defaults, addressing #1971.
Changes:
- Defaults
Content-Typetoapplication/jsonfor non-null bodies. - Preserves explicitly configured content types.
- Adds integration coverage for defaults and header preservation.
| File | Description |
|---|---|
| DevProxy.Plugins/Behavior/RateLimitingPlugin.cs | Defaults content type for custom responses. |
| DevProxy.Plugins/Behavior/GenericRandomErrorPlugin.cs | Defaults content type for error responses. |
| DevProxy.Integration.Tests/BehaviorPluginsIntegrationTests.cs | Tests defaults and explicit-header preservation. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1971
GenericRandomErrorPluginresponses andRateLimitingPlugincustom responses now getContent-Type: application/jsonwhen they have a body and noContent-Typeheader is configured. This mirrors howMockResponsePlugindefaults the content type. An explicitly configuredContent-Typeis preserved.Tests
Added integration tests in
BehaviorPluginsIntegrationTests:application/jsonapplication/json