Preserve file modes for bundled infrastructure#2179
Closed
lbussell wants to merge 4 commits into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d2766ec6-d521-4b4e-9a97-b4d3f8400e4b
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d2766ec6-d521-4b4e-9a97-b4d3f8400e4b
lbussell
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d2766ec6-d521-4b4e-9a97-b4d3f8400e4b
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d2766ec6-d521-4b4e-9a97-b4d3f8400e4b
lbussell
changed the title
Member
Author
|
Back to the drawing board for a bit... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2159 embedded infrastructure file contents and paths in ImageBuilder, but .NET embedded resources do not carry Unix file modes. As a result, the
updatecommand recreated executable helper scripts as0644, producing the mode-only changes in #2177.Generate
ContentFileModes.txtfrom Git's index and embed it alongside the infrastructure resources. ImageBuilder applies the captured mode for every file it writes on Unix, without maintaining a runtime path allowlist. A build check rejects stale generated metadata when building from a Git checkout.Validated by building the Linux ImageBuilder container and running
updateinside it: the four affected scripts are recorded by Git as100755, while regular helper scripts remain100644.