Skip to content

Reorganize includes folder#12757

Open
gewarren wants to merge 7 commits into
dotnet:mainfrom
gewarren:cleanup-061726
Open

Reorganize includes folder#12757
gewarren wants to merge 7 commits into
dotnet:mainfrom
gewarren:cleanup-061726

Conversation

@gewarren

Copy link
Copy Markdown
Collaborator

Contributes to #12513.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-io-compression

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR contributes to dotnet/dotnet-api-docs issue #12513 by reorganizing reusable markdown content under includes/ and updating API XML docs to reference the reorganized includes (or inline the content), reducing reliance on the old includes/remarks/... layout.

Changes:

  • Updated multiple XML docs to reference new include paths in ~/includes/*.md (and in several cases inlined previously-included remarks content directly into the XML).
  • Added new include fragments for String.Format, WaitHandle exitContext, and PictureBox remote-image load behavior.
  • Deleted a set of old include markdown files (primarily under includes/remarks/System.IO.Compression/...) that are no longer referenced.

Reviewed changes

Copilot reviewed 23 out of 27 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
xml/System/String.xml Updates provider-string-format include path to the reorganized includes/ root.
xml/System.Windows.Forms/PictureBox.xml Updates include path for the “Load behavior changes” content.
xml/System.Threading/WaitHandle.xml Updates include path for “Exit the context” content to a new root include.
xml/System.IO.Compression/ZipFileExtensions.xml Replaces an include with inlined remarks content.
xml/System.IO.Compression/ZipFile.xml Replaces includes with inlined remarks content for type and Open method.
xml/System.IO.Compression/ZipArchiveMode.xml Replaces an include with inlined remarks content.
xml/System.IO.Compression/ZipArchiveEntry.xml Replaces several includes with inlined remarks content.
xml/System.IO.Compression/ZipArchive.xml Replaces includes with inlined remarks content (type + ctor remarks).
xml/System.IO.Compression/DeflateStream.xml Replaces ctor remarks includes with inlined content and snippet references.
xml/System.IO.Compression/CompressionLevel.xml Replaces an include with inlined remarks content.
includes/waithandle-exit-context.md New include fragment for exitContext behavior explanation.
includes/simple-string-format.md New include fragment intended for String.Format guidance.
includes/provider-string-format.md New include fragment for provider-based String.Format guidance.
includes/picturebox-load-behavior-changes.md New include fragment documenting .NET 8 PictureBox remote load behavior change.
includes/remarks/System.IO.Compression/ZipFileExtensions/ZipFileExtensions.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/ZipFile/ZipFile.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/ZipFile/Open.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/ZipArchiveMode/ZipArchiveMode.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/ZipArchiveEntry/ZipArchiveEntry.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/ZipArchiveEntry/Name.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/ZipArchiveEntry/LastWriteTime.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/ZipArchiveEntry/FullName.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/ZipArchive/ZipArchive.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/ZipArchive/.ctor_Stream_ZipArchiveMode_Boolean_Encoding.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionLevel.md Deleted (content moved/inlined).
includes/remarks/System.IO.Compression/CompressionLevel/CompressionLevel.md Deleted (content moved/inlined).

Comment thread xml/System.IO.Compression/ZipFile.xml Outdated
Comment thread xml/System.IO.Compression/ZipArchive.xml Outdated
Comment thread xml/System.IO.Compression/ZipArchive.xml Outdated
Comment thread xml/System.IO.Compression/ZipFileExtensions.xml Outdated
Comment thread xml/System.IO.Compression/ZipArchiveEntry.xml Outdated
Comment thread xml/System.IO.Compression/ZipArchiveEntry.xml Outdated
Comment thread xml/System.IO.Compression/ZipArchiveEntry.xml Outdated
Comment thread xml/System.IO.Compression/ZipArchiveEntry.xml Outdated
Comment thread xml/System.IO.Compression/ZipFile.xml Outdated
Comment thread xml/System/String.xml
Comment thread xml/System.Xml/XmlReader.xml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 37 out of 41 changed files in this pull request and generated 3 comments.

Comment thread xml/System/String.xml Outdated
Comment thread xml/System.Xml/XmlReader.xml Outdated
Comment thread xml/System/String.xml Outdated
@gewarren gewarren marked this pull request as ready for review June 18, 2026 18:29
@gewarren gewarren requested review from a team, JeremyKuhne and merriemcgaw as code owners June 18, 2026 18:29

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. You can :shipit: when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants