Skip to content

Fix ValueOption optional args with ?param caller syntax#19742

Open
T-Gro wants to merge 1 commit into
mainfrom
fix/valueoptions-optionals
Open

Fix ValueOption optional args with ?param caller syntax#19742
T-Gro wants to merge 1 commit into
mainfrom
fix/valueoptions-optionals

Conversation

@T-Gro
Copy link
Copy Markdown
Member

@T-Gro T-Gro commented May 15, 2026

Fix caller-side ?name = expr syntax for ValueOption optional parameters when SupportValueOptionsAsOptionalParameters is enabled.

Fixes #19711

@T-Gro T-Gro requested a review from a team as a code owner May 15, 2026 12:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

@T-Gro T-Gro requested a review from abonie May 15, 2026 12:26
@T-Gro T-Gro added AI-Auto-Resolve-Conflicts Opt-in: LabelOps merges main into this PR and resolves conflicts every 3h AI-Auto-Resolve-CI Opt-in: LabelOps triages CI failures on this PR every 3h labels May 15, 2026
@T-Gro
Fix ValueOption optional args via ?param caller syntax (#19711)
a53024c 
When the SupportValueOptionsAsOptionalParameters language feature is
enabled, do not force option<_> on caller-side ?name = expr arguments
during overload inference. Leave the type as a fresh inference variable
and let AdjustCalledArgTypeForOptionals (CalleeSide) reconcile against
option<_> or voption<_>.

Pre-LangVersion-10 behaviour is preserved.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro T-Gro force-pushed the fix/valueoptions-optionals branch from 01ce17d to a53024c Compare May 15, 2026 12:26
@github-actions github-actions Bot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label May 15, 2026
@github-actions github-actions Bot mentioned this pull request May 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie Awaiting requested review from abonie

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

AI-Auto-Resolve-CI Opt-in: LabelOps triages CI failures on this PR every 3h AI-Auto-Resolve-Conflicts Opt-in: LabelOps merges main into this PR and resolves conflicts every 3h AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed

Projects

F# Compiler and Tooling
Status: New

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ValueOption optional parameters cannot be passed as ValueOptions

1 participant

@T-Gro