Skip to content

Re-enable MacCatalyst IO tests disabled by issue 114403 #131206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Re-enable MacCatalyst IO tests disabled by issue 114403 #131206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f522acd
Initial plan
Copilot Jul 22, 2026
afcf924
Re-enable MacCatalyst IO tests disabled by issue 114403
Copilot Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/libraries/System.IO.IsolatedStorage/tests/System/IO/IsolatedStorage/RemoveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ namespace System.IO.IsolatedStorage
public class RemoveTests : IsoStorageTest
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/114403", typeof(PlatformDetection), nameof(PlatformDetection.IsMacCatalyst))]
public void RemoveUserStoreForApplication()
{
TestHelper.WipeStores();
Expand All @@ -24,7 +23,6 @@ public void RemoveUserStoreForApplication()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/114403", typeof(PlatformDetection), nameof(PlatformDetection.IsMacCatalyst))]
public void RemoveUserStoreForAssembly()
{
TestHelper.WipeStores();
Expand All @@ -40,7 +38,6 @@ public void RemoveUserStoreForAssembly()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/114403", typeof(PlatformDetection), nameof(PlatformDetection.IsMacCatalyst))]
public void RemoveUserStoreForDomain()
{
TestHelper.WipeStores();
Expand All @@ -59,7 +56,6 @@ public void RemoveUserStoreForDomain()

[Theory]
[MemberData(nameof(ValidStores))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/114403", typeof(PlatformDetection), nameof(PlatformDetection.IsMacCatalyst))]
public void RemoveStoreWithContent(PresetScopes scope)
{
TestHelper.WipeStores();
Expand Down
6 changes: 1 addition & 5 deletions src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewAccessor.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,7 @@ public static IEnumerable<object[]> AccessLevelCombinationsData()
yield return new object[] { MemoryMappedFileAccess.ReadWriteExecute, MemoryMappedFileAccess.ReadWriteExecute };
yield return new object[] { MemoryMappedFileAccess.ReadExecute, MemoryMappedFileAccess.Read };
yield return new object[] { MemoryMappedFileAccess.ReadExecute, MemoryMappedFileAccess.CopyOnWrite };
// https://github.com/dotnet/runtime/issues/114403
if (PlatformDetection.IsNotMacCatalyst)
{
yield return new object[] { MemoryMappedFileAccess.ReadExecute, MemoryMappedFileAccess.ReadExecute };
}
yield return new object[] { MemoryMappedFileAccess.ReadExecute, MemoryMappedFileAccess.ReadExecute };
yield return new object[] { MemoryMappedFileAccess.CopyOnWrite, MemoryMappedFileAccess.Read };
yield return new object[] { MemoryMappedFileAccess.CopyOnWrite, MemoryMappedFileAccess.CopyOnWrite };
yield return new object[] { MemoryMappedFileAccess.ReadWrite, MemoryMappedFileAccess.Read };
Expand Down
6 changes: 1 addition & 5 deletions src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewStream.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,7 @@ public static IEnumerable<object[]> AccessLevelCombinationsData()
yield return new object[] { MemoryMappedFileAccess.ReadWriteExecute, MemoryMappedFileAccess.ReadWriteExecute };
yield return new object[] { MemoryMappedFileAccess.ReadExecute, MemoryMappedFileAccess.Read };
yield return new object[] { MemoryMappedFileAccess.ReadExecute, MemoryMappedFileAccess.CopyOnWrite };
// https://github.com/dotnet/runtime/issues/114403
if (PlatformDetection.IsNotMacCatalyst)
{
yield return new object[] { MemoryMappedFileAccess.ReadExecute, MemoryMappedFileAccess.ReadExecute };
}
yield return new object[] { MemoryMappedFileAccess.ReadExecute, MemoryMappedFileAccess.ReadExecute };
yield return new object[] { MemoryMappedFileAccess.CopyOnWrite, MemoryMappedFileAccess.Read };
yield return new object[] { MemoryMappedFileAccess.CopyOnWrite, MemoryMappedFileAccess.CopyOnWrite };
yield return new object[] { MemoryMappedFileAccess.ReadWrite, MemoryMappedFileAccess.Read };
Expand Down
Loading