Skip to content

Disable iOS LibraryMode tests by design, drop tracking-issue reference#131208

Draft
kotlarmilos with Copilot wants to merge 3 commits into
mainfrom
copilot/iosdevicelibrarymodetest
Draft

Disable iOS LibraryMode tests by design, drop tracking-issue reference#131208
kotlarmilos with Copilot wants to merge 3 commits into
mainfrom
copilot/iosdevicelibrarymodetest

Conversation

Copilot AI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The iOS.Device/Simulator.LibraryMode.Test projects were excluded from Apple-mobile runs against a tracking issue that is now being closed. Per reviewer feedback, an exclusion should either be fixed, deleted, or marked "by design" without an ActiveIssue reference.

Changes

  • src/libraries/tests.proj: Replaced the <!-- Tracking issue: ... --> comment above the two LibraryMode ProjectExclusions with a by-design comment, matching the convention used by other permanent exclusions in this file (e.g. <!-- PNSE -->).
<!-- Library mode is not supported on Apple mobile; excluded by design. Use RunDisablediOSTests=true to run locally. -->
<ProjectExclusions Include="$(RepoRoot)/src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj" />
<ProjectExclusions Include="$(RepoRoot)/src/tests/FunctionalTests/iOS/Simulator/LibraryMode/iOS.Simulator.LibraryMode.Test.csproj" />

Notes

  • The exclusion items are unchanged: tests remain off by default for Apple mobile and can still be run locally with RunDisablediOSTests=true.
  • This was the only genuine in-repo reference to the issue; the other grep hit (SlhDsaTestData.cs) is a coincidental hex substring in test-vector data.

Copilot AI review requested due to automatic review settings July 22, 2026 12:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 22, 2026 12:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI changed the title [WIP] Fix returned code issue in iOS.Device.LibraryMode.Test Disable iOS LibraryMode tests by design, drop tracking-issue reference Jul 22, 2026
Copilot AI requested a review from kotlarmilos July 22, 2026 12:46
Comment thread src/libraries/tests.proj Outdated
Copilot AI review requested due to automatic review settings July 22, 2026 18:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/libraries/tests.proj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET

3 participants