Fix up core count detection logic on android#131234
Open
eduardo-vp wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Mono’s Android CPU core-count detection to correctly parse the kernel’s /sys/devices/system/cpu/present “cpulist” format (including non-contiguous ranges), improving the accuracy of mono_cpu_count() on Android.
Changes:
- Parse
/sys/devices/system/cpu/presentas a comma-separated cpulist (single indices and ranges) rather than assuming a single0-(n-1)range. - Increase the read buffer size and add parsing success gating so malformed/partial reads fall back to existing platform logic.
- Clarify the comment describing the
/sysentry format with concrete examples.
Member
|
Do we need the same logic for CoreCLR/NAOT on Android? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse
/sys/devices/system/cpu/presentas a comma-separated cpulist (single indices and ranges) rather than assuming a single 0-(n-1) range.Closes #126417.