Repository navigation
Add common suffix length for spans - #136179
Open
RutulPatel8 wants to merge 2 commits into
Open
RutulPatel8 wants to merge 2 commits into
RutulPatel8 wants to merge 2 commits into
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-memory |
Contributor
Author
|
/azp run runtime |
|
Commenter does not have sufficient privileges for PR 136179 in repo dotnet/runtime |
Contributor
Author
|
@dotnet/area-system-memory Could an area maintainer review this contribution once the refreshed CI run completes? The previous run failed in tests outside |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the two
ReadOnlySpan<T>.CommonSuffixLengthoverloads approved in #127630.CommonPrefixLengthcounts matching elements from the start of two spans. This API counts matching elements from the end, including when the spans have different lengths. It supports default equality or a suppliedIEqualityComparer<T>.The change adds the implementation, public reference signatures, and tests for empty and unequal spans, custom comparers, reference types, and floating-point equality.
Validation:
dotnet.exe; this machine needs the Visual Studio C++ tools to build that host.