Fix time arithmetic on 32-bit systems - #316
Open
pghmcfc wants to merge 1 commit into
Open
Conversation
Commit 7cedd93 required that time_t be signed, and commit 00a26d6 dropped the define of the TIME_T_SIGNED define. However, m4/gmtime_max.m4 still used TIME_T_SIGNED, and without that we get TIME_T_MAX_BITS of 32 on 32-bit systems rather than 31. This breaks an assumption in time_max_safe_value() in src/lib/time-util.c, which results in the time_add_secs() and time_sub_secs() functions malfunctioning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Commit 7cedd93 required that
time_tbe signed, and commit 00a26d6 dropped theTIME_T_SIGNEDdefine.However,
m4/gmtime_max.m4still usedTIME_T_SIGNED, and without that we getTIME_T_MAX_BITSof 32 on 32-bit systems rather than 31. This breaks an assumption intime_max_safe_value()insrc/lib/time-util.c, which results in thetime_add_secs()andtime_sub_secs()functions malfunctioning.