Skip to content

Fix OverflowError in offsets_for_times() when timestamp is non-finite float #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koteshyelamati wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Fix OverflowError in offsets_for_times() when timestamp is non-finite float #3119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion kafka/consumer/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,7 +1228,12 @@ def offsets_for_times(self, timestamps, timeout_ms=None):
"""
timeout_ms = self.config['request_timeout_ms'] if timeout_ms is None else timeout_ms
for tp, ts in timestamps.items():
timestamps[tp] = int(ts)
try:
timestamps[tp] = int(ts)
except (ValueError, TypeError, OverflowError):
raise ValueError(
"The target timestamp for partition {} is {}. Timestamps "
"must be a valid integer (milliseconds since epoch).".format(tp, ts))
if ts < 0:
raise ValueError(
"The target time for partition {} is {}. The target time "
Expand Down