Skip to content

feat: handle historical state unavailability in deposit balance verif… #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webster-swift merged 1 commit into from
Jul 7, 2026
Merged

feat: handle historical state unavailability in deposit balance verif… #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions internal/taskmanager/event_waiting_confirmations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package taskmanager
import (
"context"
"fmt"
"strings"

"github.com/dv-net/dv-processing/internal/constants"
"github.com/dv-net/dv-processing/internal/models"
Expand All @@ -16,6 +17,16 @@ import (
"github.com/shopspring/decimal"
)

// historicalStateUnavailableSubstr matches the error returned by non-archive EVM
// nodes when asked for account state at a pruned block height. It reflects a node
// data-availability limitation, not evidence of a balance mismatch, so it must not
// block deposit webhook creation the way a real delta mismatch does.
const historicalStateUnavailableSubstr = "historical state"

func isHistoricalStateUnavailableErr(err error) bool {
return err != nil && strings.Contains(err.Error(), historicalStateUnavailableSubstr)
}

const JobKindWebhookWaitingConfirmations = "waiting_confirmations"

type WebhookWaitingConfirmationsArgs struct {
Expand Down Expand Up @@ -88,11 +99,21 @@ func (s *WebhookWaitingConfirmationsWorker) verifyEVMDepositBalanceDelta(

balanceBefore, err := s.bs.EProxy().AddressBalanceAt(ctx, job.Args.Address, assetIdentifier, job.Args.Blockchain, blockHeight-1)
if err != nil {
if isHistoricalStateUnavailableErr(err) {
s.logger.Warnf("skip deposit balance delta verification: historical state unavailable: address=%s asset=%s block=%d: %s",
job.Args.Address, assetIdentifier, blockHeight-1, err.Error())
return nil
}
return fmt.Errorf("get balance before deposit block %d: %w", blockHeight-1, err)
}

balanceAfter, err := s.bs.EProxy().AddressBalanceAt(ctx, job.Args.Address, assetIdentifier, job.Args.Blockchain, blockHeight)
if err != nil {
if isHistoricalStateUnavailableErr(err) {
s.logger.Warnf("skip deposit balance delta verification: historical state unavailable: address=%s asset=%s block=%d: %s",
job.Args.Address, assetIdentifier, blockHeight, err.Error())
return nil
}
return fmt.Errorf("get balance after deposit block %d: %w", blockHeight, err)
}

Expand Down
Loading