Remove ported instruction tests - #276
Merged
bbiiggppiigg merged 2 commits intoAug 6, 2026
Merged
Conversation
bbiiggppiigg
changed the title
bbiiggppiigg
marked this pull request as ready for review
August 4, 2026 20:28
Member
Author
|
These tests has been ported to dyninst. Remove them from testsuite so we don't have cross repo inconsistencies. |
Contributor
|
Could you split out the bluegene compiler removal? You can also remove the BlueGene/Q (bgq) compilers. |
bbiiggppiigg
force-pushed
the
bbiiggppiigg/remove-ported-instruction-tests
branch
from
August 4, 2026 21:42
09e15c0 to
2b0006e
Compare
Contributor
|
The compiler stuff was split out (thank you much), but the commits weren't removed here. |
Member
Author
I know, the plan was to rebased this on top of master after #277 goes in. |
These ten InstructionAPI tests decode fixed in-memory byte buffers and
never used a mutatee or attached to a process, so they have been ported
to the dyninst repository's integration test tree
(tests/integration/InstructionAPI/decoder/) where they run from the
build tree via ctest on any host architecture:
- power_decode.C, power_cft.C -> decoder/ppc64le/{decode,branches}.cpp
- aarch64_cft.C -> decoder/aarch64/cft.cpp
- aarch64_decode_ldst.C -> decoder/aarch64/ldst.cpp
- aarch64_simd.C -> decoder/aarch64/simd.cpp
- fucompp.C -> decoder/x86/fucompp.cpp
- mov_size_details.C -> decoder/x86/mov_size_details.cpp
- test_instruction_farcall.C -> decoder/x86/farcall.cpp
- test_instruction_bind_eval.C -> decoder/x86/bind_eval.cpp
- test_instruction_read_write.C -> decoder/x86/read_write.cpp
Remove the test sources, their blocks in
src/specification/spec-grouped.pl, and regenerate the platform
directories (gprolog 1.5.0, Makefile.genspec gen-clean gen-all). The
regenerated diffs contain exactly the removal of these tests from
test_info_new.gen.C and cmake-mutators.txt on every platform.
The remaining instruction-module tests are aarch64_decode.C (an empty
stub whose executeTest() just returns PASSED) and
test_instruction_profile.C (decodes the host's libc via SymtabAPI, so
it depends on external state and stays here for now).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bbiiggppiigg
force-pushed
the
bbiiggppiigg/remove-ported-instruction-tests
branch
from
August 5, 2026 19:44
2b0006e to
314b003
Compare
PR #270 removed the body of aarch64_decode.C (the test lives in the Dyninst integration tests now) but left a stub file, the test's specification facts, and its generated RunGroups -- so the empty test was still being scheduled and built. Remove the specification block, the stub, and regenerate the platform directories (the only generated change is the aarch64_decode disk-mode groups disappearing). Also delete files in src/instruction that nothing references: - power_instruction_table.txt / power_instruction_oprands.txt: input data of the just-removed power_decode test - ppc64_decode_test.cpp: an old standalone decoder test that was never wired into the specification or the build src/instruction keeps test_instruction_profile.C and its instruction_comp component, which remain real tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
hainest
approved these changes
Aug 6, 2026
hainest
left a comment
hainest
left a comment
Contributor
There was a problem hiding this comment.
I tested on a couple of machines with no issue. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.