refactor(envd): extract inlined request/response bodies to OpenAPI components#2932
refactor(envd): extract inlined request/response bodies to OpenAPI components#2932mishushakov wants to merge 3 commits into
Conversation
mishushakov
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
PR SummaryLow Risk Overview Regenerated oapi-codegen output and updated envd handlers/tests, the orchestrator’s Reviewed by Cursor Bugbot for commit 62c4699. Bugbot is set up for automated code reviews on this repo. Configure here. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Move the inlined /init and /files/compose request bodies and the /metrics, /envs, /files/compose response bodies into reusable components/requestBodies and components/responses. Regenerated api.gen.go gains named aliases only; operation-derived types are preserved, so handlers are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Switch the init and compose handlers (and their tests) to the new component-derived types — Init, Compose, and ComposeSuccess — instead of the operation-derived JSON body types. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mishushakov
force-pushed
the
mishushakov/envd-extract-body-components
branch
from
e141c54 to
6dbcfe4
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
1 similar comment
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Pull the /init request body's inline object schema into a named components/schemas/InitRequest, and move the /collapse 200 response (added on main) into components/responses/CollapseSuccess to match the convention used by the other endpoints. This also drops the duplicate PostInitJSONBody struct in favor of a single InitRequest type. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mishushakov
force-pushed
the
mishushakov/envd-extract-body-components
branch
from
29b7c75 to
62c4699
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
2 participants
Moves the inlined request and response bodies in the envd OpenAPI spec into reusable
components/requestBodies(Init,Compose) andcomponents/responses(Metrics,EnvVars,ComposeSuccess), with each operation now referencing them via$ref. Regeneratedapi.gen.gogains only named type aliases — the operation-derived types likePostInitJSONBodyare preserved, so handlers are unchanged. Verified withgo build,go vet, andgolangci-lint.🤖 Generated with Claude Code