Repository navigation
Fix unified diff code mining layout and footer painting - #3068
Merged
tobiasmelcher merged 1 commit intoNov 11, 2026
Merged
tobiasmelcher merged 1 commit into
tobiasmelcher merged 1 commit into
Conversation
Mark resolved annotations deleted before removing them so the painter clears their reserved line height. Synchronize footer drawing and disposal, and use the measured height to prevent cache invalidation from causing a null pointer exception.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting a hunk removed its line header without marking it deleted, so the editor could keep the space reserved for that header. Mark the annotations deleted before removing them so the space is cleared and the remaining hunk stays aligned.
Footer painting could also throw a NullPointerException when disposal cleared its cached rectangle during a draw. Drawing and disposal now share a lock, and border painting uses the height measured by the current draw call. Regression tests cover the layout after reverting a hunk and disposal during plain and styled footer painting.