Skip to content

[2329] Fix importing requirements as text#2328

Merged
AxelRICHARD merged 1 commit into
mainfrom
pcd/fix/requirement-feature-membership
Jul 6, 2026
Merged

[2329] Fix importing requirements as text#2328
AxelRICHARD merged 1 commit into
mainfrom
pcd/fix/requirement-feature-membership

Conversation

@pcdavid

@pcdavid pcdavid commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@pcdavid pcdavid linked an issue Jul 2, 2026 that may be closed by this pull request
@pcdavid pcdavid force-pushed the pcd/fix/requirement-feature-membership branch from 211d0a5 to d79aa7f Compare July 2, 2026 06:59
@pcdavid pcdavid changed the title [fix] Fix the membership used when importing (as text) a requirement inside a requirement [2329] Fix the membership used when importing (as text) a requirement inside a requirement Jul 2, 2026
@AxelRICHARD AxelRICHARD added this to the 2026.7.0 milestone Jul 2, 2026
@AxelRICHARD

Copy link
Copy Markdown
Member

@pcdavid I think you could add a new test in MutationInsertTextualSysMLv2DataFetcherTests to ensure non-regression

@pcdavid pcdavid force-pushed the pcd/fix/requirement-feature-membership branch from d79aa7f to 0bc1dab Compare July 6, 2026 14:20
@pcdavid

pcdavid commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@pcdavid I think you could add a new test in MutationInsertTextualSysMLv2DataFetcherTests to ensure non-regression

Done in the new version.

@pcdavid pcdavid changed the title [2329] Fix the membership used when importing (as text) a requirement inside a requirement [2329] Fix importing requirements as text inside a requirement Jul 6, 2026
@pcdavid pcdavid changed the title [2329] Fix importing requirements as text inside a requirement [2329] Fix importing requirements as text Jul 6, 2026
Bug: #2329
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@AxelRICHARD AxelRICHARD force-pushed the pcd/fix/requirement-feature-membership branch from 0bc1dab to a949203 Compare July 6, 2026 15:06
@AxelRICHARD AxelRICHARD merged commit 42af534 into main Jul 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing requirement from text is broken

2 participants