Skip to content

[2336] Fix edit expression modal when the selected element is a FeatureValue#2339

Merged
AxelRICHARD merged 1 commit into
mainfrom
pcd/fix/feature-value-expression
Jul 6, 2026
Merged

[2336] Fix edit expression modal when the selected element is a FeatureValue#2339
AxelRICHARD merged 1 commit into
mainfrom
pcd/fix/feature-value-expression

Conversation

@pcdavid

@pcdavid pcdavid commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Draft until I complete the tests.

Bug: #2336
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@pcdavid pcdavid marked this pull request as draft July 6, 2026 11:53
@pcdavid pcdavid added this to the 2026.7.0 milestone Jul 6, 2026
@pcdavid pcdavid force-pushed the pcd/fix/feature-value-expression branch 2 times, most recently from aad4c05 to 2b217a6 Compare July 6, 2026 14:46
@pcdavid pcdavid marked this pull request as ready for review July 6, 2026 14:47
@AxelRICHARD AxelRICHARD force-pushed the ari/enh/2325 branch 2 times, most recently from 66e611f to 3184175 Compare July 6, 2026 15:24
@AxelRICHARD

Copy link
Copy Markdown
Member

@pcdavid I will rebase and merge this PR after the merge of #2337

Base automatically changed from ari/enh/2325 to main July 6, 2026 16:37
@AxelRICHARD AxelRICHARD force-pushed the pcd/fix/feature-value-expression branch from 2b217a6 to 911b6c9 Compare July 6, 2026 16:39
Bug: #2336
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@AxelRICHARD AxelRICHARD force-pushed the pcd/fix/feature-value-expression branch from 911b6c9 to b9f7b1f Compare July 6, 2026 16:46
@AxelRICHARD AxelRICHARD merged commit 21834e8 into main Jul 6, 2026
4 checks passed
@AxelRICHARD AxelRICHARD deleted the pcd/fix/feature-value-expression branch July 6, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit expression popup does not display expression on FeatureValue elements

2 participants