fix: respect plugins_loading.enabled config in zenohd#2461
Open
varunkamath wants to merge 1 commit intoeclipse-zenoh:mainfrom
Open
fix: respect plugins_loading.enabled config in zenohd#2461varunkamath wants to merge 1 commit intoeclipse-zenoh:mainfrom
plugins_loading.enabled config in zenohd#2461varunkamath wants to merge 1 commit intoeclipse-zenoh:mainfrom
Conversation
zenohd unconditionally set `plugins_loading.enabled = true`, ignoring the user's configuration. Now plugin loading is only force-enabled when CLI args require it (`--plugin`, `--rest-http-port`, or `--plugin-search-dir`), preserving the documented behavior. Fixes eclipse-zenoh#2422 Signed-off-by: Varun Kamath <varunkamath@gmail.com>
varunkamath
force-pushed
the
fix/respect-plugins-loading-config
branch
from
5e5c478 to
084f0a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
Makes
zenohdrespect the user'splugins_loading.enabledconfiguration setting. Previously,zenohdunconditionally calledconfig.plugins_loading.set_enabled(true), which overrode the user's config and caused plugins to load even whenplugins_loading.enabledwas not set totrue.Now plugin loading is only force-enabled when CLI args require it:
--plugin(explicitly loading a plugin)--rest-http-port(implicitly requires the REST plugin)--plugin-search-dir(implies plugin usage)Why is this change needed?
The documented behavior states that plugins are only loaded if
plugins_loading: { enabled: true }, but zenohd was ignoring this and always enabling plugin loading. This caused unexpected plugin load attempts and confusing error messages.Related Issues
Fixes #2422
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
bug🐛 Bug Fix Requirements
Since this PR is labeled as a bug fix, please ensure:
Why this matters: Bugs without tests often reoccur.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.