Dockefile/buildspec changes for faster buildtime; Some CF changes#80
Merged
Conversation
…ildx changes for caching
…nto feature/cf-changes
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
…nto feature/cf-changes
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…nto feature/cf-changes
emondal1026
approved these changes
Jul 14, 2026
jkaserEA
approved these changes
Jul 14, 2026
ea-mtenhoor
reviewed
Jul 14, 2026
| COPY --chown=app:app package.json package-lock.json ./ | ||
| RUN npm ci | ||
|
|
||
| COPY --chown=app:app . . |
There was a problem hiding this comment.
I think we discussed this in a PR for one of the Shiny apps. Does the app user need to be able to modify these files? If not, we should probably leave root as the owner and just give app read access.
| FROM public.ecr.aws/docker/library/node:22-alpine | ||
|
|
||
| WORKDIR /usr/src/app | ||
| RUN adduser -D -s /bin/sh app && mkdir -p /usr/src/app && chown app:app /usr/src/app |
There was a problem hiding this comment.
I looks like the old adduser command included -H to skip creating a home directory. Why was that removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Docker images (
app/Dockerfile,executor/Dockerfile)chown -R-ing everything at the end. The new process drastically shortens the backend buildtime.package.json/package-lock.json,requirements.txt), install deps, then copy the rest of the source — so dependency layers aren't invalidated onevery source change.
CodeBuild buildspecs (
app/api/buildspec.yml,executor/buildspec.yml)docker build --cache-from(pull :latest) todocker buildx buildusing a docker-container builder. This portion was duplicated from Rally buildspec configurations.CloudFormation (
cloudformation/templates/1-main.yml,x-parameter-values.md)CreateExecutorS3Bucketparameter (defaults toThe S3 Bucket already exists) and wire it into the executor CodePipeline stack's CreateS3Bucket. When testing new deployments of Runway in a different AWS account, the deployment was erroring due to theCreateS3Bucketparameter being used for two different resources.OAuth2Issuerto the Beanstalk metadata.This was tested in
akitson-runway-dev.