fix double call of beforeOpen while Link navigated#59
Draft
sergeysova wants to merge 2 commits into
Draft
Conversation
Opening a route with a beforeOpen handler via route.open() (what <Link> does) runs openFx once, then navigate -> locationUpdated -> navigated -> navigatedFx re-runs openFx, executing beforeOpen a second time and briefly leaving the route unopened (the reported 404 flash). Refs: #53
Track the key of an in-flight imperative open() so its navigation echo settles the route without re-running beforeOpen and parent guards; external navigation (history.push) still runs them once.
|
|
|
sergeysova
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #53
Type of change
Checklist
pnpm buildpassespnpm typecheckpassespnpm testpasses and I added/updated tests for my changepnpm lintpassespnpm changeset), or an empty one for no-release changes (pnpm changeset --empty)