Fix cell backgrounds for self-closing tcPr tags - #664
Closed
ahmetmusab42-stack wants to merge 1 commit into
Closed
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<w:tcPr />before inserting cell shading<w:shd>inside<w:tcPr>so Word preserves the backgroundVerification
uv run python tests/cellbg_shorthand.pyuv run flake8 docxtpl tests setup.py --count --max-line-length=127 --show-source --statisticsdocument4.docxattachment from Cell background tags do not work in docx files with shorthand tags (i.e., with <w:tcPr /> instead of <w:tcPr>...</w:tcPr>) #559 and verifiedword/document.xmlcontains<w:tcPr><w:shd .../></w:tcPr>with no direct<w:tc>/<w:shd>childuv buildFixes #559