Skip to content

Fix cell backgrounds for self-closing tcPr tags - #664

Closed
ahmetmusab42-stack wants to merge 1 commit into
elapouya:masterfrom
ahmetmusab42-stack:fix-cellbg-shorthand-tcpr
Closed

Fix cell backgrounds for self-closing tcPr tags#664
ahmetmusab42-stack wants to merge 1 commit into
elapouya:masterfrom
ahmetmusab42-stack:fix-cellbg-shorthand-tcpr

Conversation

@ahmetmusab42-stack

Copy link
Copy Markdown

Summary

  • normalize a self-closing <w:tcPr /> before inserting cell shading
  • keep the generated <w:shd> inside <w:tcPr> so Word preserves the background
  • add a focused regression test for shorthand table-cell properties

Verification

Fixes #559

@ahmetmusab42-stack

Copy link
Copy Markdown
Author

I missed #656 when checking for overlapping work. It already fixes #559 more comprehensively by covering both cellbg and colspan, with broader regression coverage. Closing this as a duplicate rather than asking maintainers to review redundant work. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cell background tags do not work in docx files with shorthand tags (i.e., with <w:tcPr /> instead of <w:tcPr>...</w:tcPr>)

1 participant